Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gecko glue for grid-auto-flow #16025

Closed
wafflespeanut opened this issue Mar 18, 2017 · 6 comments
Closed

Add gecko glue for grid-auto-flow #16025

wafflespeanut opened this issue Mar 18, 2017 · 6 comments

Comments

@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Mar 18, 2017

#16024 adds parsing/serialization for grid-auto-flow. We need to add the gecko glue for it.

@wafflespeanut
Copy link
Member Author

@wafflespeanut wafflespeanut commented Mar 18, 2017

This should be pretty simple. Firstly, we should change the Mako definition for grid-auto-flow (in components/style/properties/longhands/position.rs) to have products='gecko' (so that we enable it for Stylo). Now, we should add set and copy methods manually (in gecko.mako.rs).

The first step is to add grid-auto-flow to this list, indicating that we're going manual. Then, we should add a new method set_grid_auto_flow which takes a similar signature as that of the methods that are already present there. This is the type of the value we should be comparing against while setting it in gecko. Once that's done, call the impl_simple_copy just like the surrounding methods.

If everything goes well, then ./mach build-geckolib will succeed.

@highfive
Copy link

@highfive highfive commented Mar 18, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@wafflespeanut
Copy link
Member Author

@wafflespeanut wafflespeanut commented Mar 18, 2017

@o0Ignition0o You wanna try this?

@wafflespeanut
Copy link
Member Author

@wafflespeanut wafflespeanut commented Mar 21, 2017

This is open for anyone!

@methyl
Copy link
Contributor

@methyl methyl commented Mar 22, 2017

@highfive: assign me

@highfive
Copy link

@highfive highfive commented Mar 22, 2017

Hey @methyl! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned label Mar 22, 2017
@methyl methyl mentioned this issue Mar 22, 2017
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Mar 22, 2017
Stylo: Add gecko glue for grid-auto-flow

- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16025 (github issue number if applicable).
- [x] These changes do not require tests because we don't test gecko glue code

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16076)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.