Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor native_font, etc to live in platform/library directories #161
Comments
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this issue
Sep 7, 2014
Test that XHR abort() should not fire an "abort" event after a timeout happens. (reviewed by annevk)
glennw
pushed a commit
to glennw/servo
that referenced
this issue
Jan 16, 2017
in the fragment shader. This reintroduces the clip-in rect in the FS. Since we'll need it anyway when we have arbitrary matrix/clip stacks, this seems harmless. Color strips for non-axis-aligned linear gradients are submitted as axis-aligned rects centered at the appropriate point, just as axis-aligned ones are. However, we reuse one of the vertex fields to store the rotation angle. The vertex shader detects this condition, rotates the rectangle around its midpoint, and passes the clip rect on to the fragment shader. Additionally, this patch eliminates the ugly (-10000,10000) spans for linear gradient strips that we had before. It was necessary to tighten this up in order to avoid needless fragment shader invocations in the non-axis-aligned case, so I went ahead and fixed it everywhere. Closes servo#161.
glennw
pushed a commit
to glennw/servo
that referenced
this issue
Jan 16, 2017
1. When the first stop of a gradient was not at position 0%, WebRender did not draw the solid color from 0% to that first stop, in violation of CSS-IMAGES-3. 2. Certain gradient angles would cause the segments to be too narrow. This patch fixes this by correcting the trigonometric calculations. Closes servo#161.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current pattern is to put multiple implementations in a single directory (such as src/servo/text/native_font/) and then conditionally typedef them in a top-level native_font.rs file. This won't scale very well wrt. number of folders. It's also easier to bulk include/exclude an entire directory from a specific build configuration.
Instead, library/platforms get their own directory. For example, quartz, harfbuzz, freetype.