Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root element with absolute positioning ignores min-width #16248

Closed
jdm opened this issue Apr 3, 2017 · 1 comment
Closed

Root element with absolute positioning ignores min-width #16248

jdm opened this issue Apr 3, 2017 · 1 comment
Assignees
@mbrubeck
Labels
A-layout/block A-webcompat C-has-manual-testcase

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 3, 2017

This is related to #15571, but that issue is related to the background being clipped incorrectly.

<style>
  html {
    position: absolute;
    min-width: 100%;
    border: 1px solid black;
  }
</style>
<body>
  One account. All of Google.
</body>

In Firefox the border fills the viewport width, while in Servo it fills the viewport height but only a small portion of the viewport width.
@jdm
Copy link
Member Author

@jdm jdm commented Apr 3, 2017

This is the cause of the misalignment for the Google sign in page.
@mbrubeck mbrubeck self-assigned this Apr 3, 2017
@stshine stshine mentioned this issue Apr 13, 2017
Open
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 15, 2017
@mbrubeck
Fix containing block size for absolute root element
d9ab9c3 
Fixes servo#16248.
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 15, 2017
@mbrubeck
Fix containing block size for absolute root element
a1b012d 
Fixes servo#16248.
@mbrubeck mbrubeck mentioned this issue May 15, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue May 16, 2017
@bors-servo
Auto merge of #16881 - mbrubeck:absolute_root, r=<try>
Loading status checks…
ef7ef08 
Fix containing block size for absolute root element

The root element doesn't have a containing block, so use the viewport size instead of `self.base.absolute_cb`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16248 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16881)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 16, 2017
@bors-servo
Auto merge of #16881 - mbrubeck:absolute_root, r=<try>
Loading status checks…
5a8c919 
Fix containing block size for absolute root element

The root element doesn't have a containing block, so use the viewport size instead of `self.base.absolute_cb`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16248 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16881)
<!-- Reviewable:end -->
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 16, 2017
@mbrubeck
Fix containing block size for absolute root element
e34cf4f 
Fixes servo#16248.
bors-servo added a commit that referenced this issue May 18, 2017
@bors-servo
Auto merge of #16881 - mbrubeck:absolute_root, r=stshine
Loading status checks…
10cc59d 
Fix containing block size for absolute root element

The root element doesn't have a containing block, so use the viewport size instead of `self.base.absolute_cb`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16248 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16881)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
A-layout/block A-webcompat C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix containing block size for absolute root element
2 participants
@mbrubeck @jdm
You can’t perform that action at this time.