Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support processing network response body notifications on background threads #16304

Open
jdm opened this issue Apr 7, 2017 · 2 comments
Open

Support processing network response body notifications on background threads #16304

jdm opened this issue Apr 7, 2017 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 7, 2017

This is a feature that Gecko supports - for responses where nothing useful can be done until the full response body is present, there's no reason to queue an event in the main thread that just pushes data to a buffer. If the buffer is threadsafe, that pushing can happen in a background thread while the main thread works on more important things. We should make it easy to opt-in to this optimization.

@nox
Copy link
Member

@nox nox commented Apr 11, 2017

@jdm Does the buffer even needs to be threadsafe? Can't we just send it to main thread once all the data has been accumulated?

@jdm
Copy link
Member Author

@jdm jdm commented Apr 11, 2017

That's a good point!

@jdm jdm added the I-perf-slow label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.