Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for <object> #1636

Closed
SimonSapin opened this issue Feb 7, 2014 · 2 comments
Closed

Basic support for <object> #1636

SimonSapin opened this issue Feb 7, 2014 · 2 comments

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 7, 2014

Needed for #1366 (Acid2). CC @recrack

The <object> element is kind of a mix of <img> and <iframe>. As a first step (which should be enough for Acid2), I suggest we treat it like <img> with two differences:

  • The resource’s URL is given by the data attribute instead of src,
  • and the fallback (used when the resource fails to load) is given by the element’s content (ie. until the </object> closing tag) instead of the alt attribute. (As with <img alt>, the fallback is not shown at all when the resource does load.)
@recrack
Copy link
Contributor

@recrack recrack commented Feb 10, 2014

@SimonSapin Thanks for the suggestion!

bors-servo pushed a commit that referenced this issue Feb 20, 2014
Support for #1636

Now, we can see eyes in acid2.html :)
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 11, 2014

Fixed.

@pcwalton pcwalton closed this Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.