Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parsing and serialization of touch-action property #16372

Closed
upsuper opened this issue Apr 12, 2017 · 7 comments
Closed

Implement parsing and serialization of touch-action property #16372

upsuper opened this issue Apr 12, 2017 · 7 comments
Labels
A-content/css A-stylo
Milestone
Stylo: test_value...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Apr 12, 2017

https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

Gecko seems to support none, auto, pan-x, pan-y, and manipulation. We need to support them in stylo.
@highfive
Copy link

@highfive highfive commented Apr 12, 2017

cc @emilio
@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Apr 14, 2017

To which *.mako.rs should this property be added? I did not find one obviously correct.
@canova
Copy link
Member

@canova canova commented Apr 14, 2017

It should be in box.mako.rs. We generally use the same struct architecture as gecko and in gecko, touch-action is in nsStyleDisplay struct. It corresponds to Box in Servo. As far as I remember there was a chart that shows which struct corresponds to which(in wiki or somewhere) but I couldn't find it.
@ferjm
Copy link
Member

@ferjm ferjm commented Apr 17, 2017

@canaltinova this might be the chart you were referring to https://public.etherpad-mozilla.org/p/aligning-style-structs
@canova
Copy link
Member

@canova canova commented Apr 17, 2017

@ferjm Ah yes, this is it. Thanks!
@nox
Copy link
Member

@nox nox commented Apr 20, 2017

@pyfisch Are you working on this?
@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Apr 20, 2017

No, I just looked at it.
nox added a commit to nox/servo that referenced this issue May 2, 2017
@nox
Implement touch-action in stylo (fixes servo#16372)
65d0771
bors-servo added a commit that referenced this issue May 2, 2017
@bors-servo
Auto merge of #16693 - nox:touch-action, r=emilio
Loading status checks…
5e2d383 
Implement touch-action in stylo (fixes #16372)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16693)
<!-- Reviewable:end -->
@bors-servo bors-servo closed this in 5684acc May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css A-stylo
Projects
None yet
Milestone
Stylo: test_value...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@nox @upsuper @canova @ferjm @pyfisch @highfive
You can’t perform that action at this time.