Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also upload the zipfile of Windows with the nightly build #16437

Closed
larsbergstrom opened this issue Apr 13, 2017 · 7 comments
Closed

Also upload the zipfile of Windows with the nightly build #16437

larsbergstrom opened this issue Apr 13, 2017 · 7 comments

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Apr 13, 2017

For users without administrative priviledges, it would be nice to have a zipfile that can be unpacked to try out the Servo Windows nightly.

We already build it during the packaging process:
https://github.com/servo/servo/blob/master/python/servo/package_commands.py#L342

The change required should be to update the upload scripts to push up both the zipfile and the MSI:
https://github.com/servo/servo/blob/master/etc/ci/upload_nightly.sh#L94

@highfive
Copy link

@highfive highfive commented Apr 13, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@highfive
Copy link

@highfive highfive commented Apr 13, 2017

@highfive
Copy link

@highfive highfive commented Apr 13, 2017

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 13, 2017

We'll also need to update the download.servo.org website to link to the new zipfile Windows build so that's it's easy to download. This involves updating the index.html file in that repository to add the new link, and update the existing Windows build link to mention that it's an MSI.

@UK992
Copy link
Contributor

@UK992 UK992 commented Apr 14, 2017

@highfive: assign me

@highfive highfive added the C-assigned label Apr 14, 2017
@highfive
Copy link

@highfive highfive commented Apr 14, 2017

Hey @UK992! Thanks for your interest in working on this issue. It's now assigned to you!

@UK992 UK992 mentioned this issue Apr 14, 2017
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Apr 18, 2017
Upload zipfile of Windows nightly build

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16437

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16464)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 18, 2017

We still need to update the download.servo.org repository so that the new zip builds are linked from the main page.

@aneeshusa aneeshusa reopened this Apr 18, 2017
bors-servo added a commit to servo/download.servo.org that referenced this issue Apr 19, 2017
Add Windows ZIP download link

Fixes servo/servo#16437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.