Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows nightly uploads are failing #16560
Comments
|
cc @aneeshusa |
|
I'm not sure, but this might be caused by servo/saltfs#640. @larsbergstrom @metajack any ideas? |
|
If so, the easiest solution is probably to convert the upload script to Python, instead of reinstalling MinGW/MSYS. |
|
I'm also not sure if we need to re-install s3cmd/what's the best way to do that, given #12231. |
|
I'm not sure we wanted to remove msys/mingw, see servo/saltfs#640 (comment) Sorry I missed that earlier issue convo. I would certainly be in favor of using a python upload script instead (there must be one for s3 uploads). I assume the complexity there will mainly be in getting all the secret API keys, etc. in the right places and not being accidentally logged :-) |
|
Re: servo/saltfs#640 (comment) The script is fairly short, I can do a rewrite today (e.g. before the next set of nightlies). Buildbot takes care of passing credentials as environment variables and not logging them. |
|
@aneeshusa Thanks, that's great :-) |
|
Has there been any progress on this? The Windows installer hasn't been updated for a week now. |
|
@atouchet There are open PRs (servo/saltfs#642 and #16565) awaiting review by @larsbergstrom |
|
@aneeshusa I don't mean to be a pain but are you still working on this? |
|
Should we consider rolling back the manual removal of the mingw stuff for now from the Windows builders until we can do the python2 rewrite? |
|
I updated the PR, I don't think I actually needed to make any changes for it to work on Python 2 instead of 3 :) |
…, r=metajack Convert nightly upload script to Python Now that MinGW and MSYS have been removed from the Windows builders, bash is not available to run the previous upload_nightlies.sh script. Convert the script to Python 2 for cross-platform support. Additionally, switch to the `boto3` library for easy uploading without needing to install `s3cmd`, and move the code into mach for easy `boto3` installation as the new `./mach upload-nightly` command. Also, hard-code the paths to the packages instead of using globs to look for them, as the paths are static. (The paths used to contain timestamps, but we now insert timestamps when uploading to S3 to improve reproducibility.) <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #16560 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because Buildbot will test them. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16565) <!-- Reviewable:end -->
|
I believe this requires servo/saltfs#675 to be merged. The builds on the website are still out of date. |
|
@aneeshusa @larsbergstrom @metajack I don't think this has actually been fixed yet. The latest nightly on the Servo website is still a build from last month. Can this issue be re-opened? |
|
@edunham servo/saltfs#675 is still marked needs deploy. Do you know when we last deployed the latest saltfs changes? |
|
@jdm I think this has been fixed now. I just checked the latest installer and it says it is a day old. |
|
Thanks! |
http://build.servo.org/builders/windows-msvc-nightly/builds/120/steps/shell__2/logs/stdio