Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport border-image-outset for gradients #16638
Closed
Labels
Comments
bors-servo
added a commit
that referenced
this issue
May 1, 2017
Improvements to gradients. This is a collection of commits improving the rendering of linear and radial gradients by making them conform more closely to the spec. All commits are are independent and should work without the others. These commits address the following issues: * a956e3f resolves #3908 but contains also some other necessary changes to `convert_gradient_stops`. The updated function has a few more copys but should be more correct. Maybe @pcwalton wants to comment since he has originally written the code. * b230be8 partially solves #16638. (Partially because `border-image-outset` is not implemented. This is an older issue for border gradients: #15894. To quickly catch regressions and see changes to gradients I have created [a set of twelve manual testcases](https://pyfisch.org/stuff/testcases-gradients.html) and placed them in a single file. Attached are two files. One shows how the gradients were rendered before the PR the other one with the changes applied.   r? @emilio and maybe also @jdm? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16666) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 7, 2017
Improvements to gradients. This is a collection of commits improving the rendering of linear and radial gradients by making them conform more closely to the spec. All commits are are independent and should work without the others. These commits address the following issues: * a956e3f resolves #3908 but contains also some other necessary changes to `convert_gradient_stops`. The updated function has a few more copys but should be more correct. Maybe @pcwalton wants to comment since he has originally written the code. * b230be8 partially solves #16638. (Partially because `border-image-outset` is not implemented. This is an older issue for border gradients: #15894. To quickly catch regressions and see changes to gradients I have created [a set of twelve manual testcases](https://pyfisch.org/stuff/testcases-gradients.html) and placed them in a single file. Attached are two files. One shows how the gradients were rendered before the PR the other one with the changes applied.   r? @emilio and maybe also @jdm? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16666) <!-- Reviewable:end -->
pyfisch
changed the title
This was referenced May 7, 2017
bors-servo
added a commit
that referenced
this issue
May 14, 2017
Implement border-image-outset. The border is moved correctly but linear gradients and some images will not be scaled correctly. These depend on border-image-slice and better webrender support. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix (partially) #16638 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16796) <!-- Reviewable:end -->
pyfisch
added a commit
to pyfisch/servo
that referenced
this issue
May 2, 2018
Add an automatic test for border-image-outset with a gradient. Convert two tests from UTF-8 LE with CRLF line endings to UTF-8 with LF endings as the old files could not be viewed with servo. Closes servo#16638
bors-servo
added a commit
that referenced
this issue
May 2, 2018
Implement border-image-outset Add an automatic test for border-image-outset with a gradient. Convert two tests from UTF-8 LE with CRLF line endings to UTF-8 with LF endings as the old files could not be viewed with servo. Closes #16638 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20739) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 2, 2018
Implement border-image-outset Add an automatic test for border-image-outset with a gradient. Convert two tests from UTF-8 LE with CRLF line endings to UTF-8 with LF endings as the old files could not be viewed with servo. Closes #16638 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20739) <!-- Reviewable:end -->
Moggers
added a commit
to Moggers/servo
that referenced
this issue
Jun 13, 2018
Add an automatic test for border-image-outset with a gradient. Convert two tests from UTF-8 LE with CRLF line endings to UTF-8 with LF endings as the old files could not be viewed with servo. Closes servo#16638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Radial gradients are only implemented for backgrounds but not for borders.Implement
border-image-outsetproperty for gradient borders.follow up of #16385