Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run JetStream benchmark #16701

Closed
jdm opened this issue May 2, 2017 · 7 comments

Comments

@jdm
Copy link
Member

commented May 2, 2017

Get JetStream working in Servo. Jetstream is here http://browserbench.org/JetStream/

This metabug is specifically just to get it running. Performance issues will be tracked in a separate metabug.

  • javascript: url isn't handled correctly #16718

Part of #16717.

@jdm jdm added the A-content/script label May 2, 2017

@metajack metajack referenced this issue May 3, 2017

Open

Support common browser benchmarks in Servo #16717

1 of 4 tasks complete

@metajack metajack added the B-meta label May 3, 2017

@metajack

This comment has been minimized.

Copy link
Contributor

commented May 3, 2017

Making this a meta bug.

@metajack metajack changed the title JetStream benchmark doesn't work (javscript: url isn't handled correctly) Run JetStream benchmark May 3, 2017

@metajack metajack added the E-easy label May 3, 2017

@highfive

This comment has been minimized.

Copy link

commented May 3, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@metajack

This comment has been minimized.

Copy link
Contributor

commented May 3, 2017

Marking this easy. The task here is to run Servo on this benchmark and file bugs for any errors you find that prevent it from running.

@bspeice

This comment has been minimized.

Copy link

commented Jun 6, 2017

@highfive: assign me

First up is a certificate handshake issue. Happy to provide more info/circumvent the checks if someone can point me in the right direction! (This was run on a release build, commit ID 9987cb1 on master)
image

@highfive

This comment has been minimized.

Copy link

commented Jun 6, 2017

Hey @bspeice! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned label Jun 6, 2017

@bspeice

This comment has been minimized.

Copy link

commented Jun 6, 2017

Also confirmed #16718, likely fixed by #15147; The JetStream object is undefined (it's created by JetStreamDriver.js) when the test tries to kick off.

EDIT: Sorry for all the edits, I'll keep this shorter in the future. The SSL error is related to a bad certificate in general; Servo defaulted to HTTPS when I didn't specify it, and Firefox also errored out on the page:

An error occurred during a connection to browserbench.org. SSL received a record that exceeded the maximum permissible length. Error code: SSL_ERROR_RX_RECORD_TOO_LONG

@jdm jdm removed the E-easy label Aug 18, 2017

@jdm

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2017

The benchmark now works correctly!

@jdm jdm closed this Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.