Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete paint threads option #16716

Closed
metajack opened this issue May 3, 2017 · 3 comments · Fixed by #16757
Closed

remove obsolete paint threads option #16716

metajack opened this issue May 3, 2017 · 3 comments · Fixed by #16757
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@metajack
Copy link
Contributor

metajack commented May 3, 2017

Paint threads used to control how many threads we split CPU painting over. Since we no longer have CPU painting, this option is currently doing nothing and should be removed. All uses seem to be shown here: https://github.com/servo/servo/search?utf8=%E2%9C%93&q=paint_threads&type=
@metajack metajack added the E-less-complex Straightforward. Recommended for a new contributor. label May 3, 2017
@highfive
Copy link

highfive commented May 3, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@divagant-martian
Copy link

@highfive: assign me

@highfive highfive added the C-assigned There is someone working on resolving the issue label May 4, 2017
@highfive
Copy link

highfive commented May 4, 2017

Hey @zombiefungus! Thanks for your interest in working on this issue. It's now assigned to you!

divagant-martian pushed a commit to divagant-martian/servo that referenced this issue May 7, 2017
Remove obsolete paint threads option servo#16716
9591d1e
@divagant-martian divagant-martian mentioned this issue May 7, 2017
Merged
5 tasks
bors-servo pushed a commit that referenced this issue May 7, 2017
Auto merge of #16757 - zombiefungus:issue16716, r=KiChjang
c171ded 
Remove obsolete paint threads option #16716

<!-- Please describe your changes on the following line: -->
Remove paint_threads from `ports/cef/core.rs` and `components/config/opts.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16716

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16757)
<!-- Reviewable:end -->
@mbrubeck mbrubeck mentioned this issue Nov 10, 2017
Merged
3 tasks
bors-servo pushed a commit that referenced this issue Nov 10, 2017
Auto merge of #19181 - mbrubeck:opts, r=emilio
3d888b5 
Remove unused -t command-line flag

A little bit was left over from #16716.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only remove unused code

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19181)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove obsolete paint threads option #16716 divagant-martian/servo
3 participants
@metajack @highfive @divagant-martian