Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo: Bug 1361994 - Implement access to CSSMozDocumentRule #16797

Merged
merged 1 commit into from May 11, 2017

Conversation

ferjm
Copy link
Contributor

@ferjm ferjm commented May 10, 2017

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1361994


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/gecko/arc_types.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/gecko/arc_types.rs, ports/geckolib/glue.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 10, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented May 10, 2017

@bors-servo: delegate+

@bors-servo
Copy link
Contributor

✌️ @ferjm can now approve this pull request

@ferjm
Copy link
Contributor Author

ferjm commented May 10, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

📌 Commit 79e9168 has been approved by xidorn

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 10, 2017
@upsuper
Copy link
Contributor

upsuper commented May 10, 2017

@bors-servo r-

Don't land anything before vcs-sync is back.

@ferjm
Copy link
Contributor Author

ferjm commented May 10, 2017

Ouch! Sorry, just saw the email about vcs-sync

@bholley
Copy link
Contributor

bholley commented May 10, 2017

VCS sync is back now.

@ferjm
Copy link
Contributor Author

ferjm commented May 11, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

📌 Commit 79e9168 has been approved by xidorn

@bors-servo
Copy link
Contributor

⌛ Testing commit 79e9168 with merge 7281668...

bors-servo pushed a commit that referenced this pull request May 11, 2017
Stylo: Bug 1361994 - Implement access to CSSMozDocumentRule

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1361994

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16797)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: xidorn
Pushing 7281668 to master...

@bors-servo bors-servo merged commit 79e9168 into servo:master May 11, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 11, 2017
@ferjm ferjm deleted the bug1361994.mozdocument.cssom branch May 11, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants