Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The compositor's viewport field and the WindowEvent::Viewport message are never used #16809

Open
paulrouget opened this issue May 11, 2017 · 3 comments
Open

The compositor's viewport field and the WindowEvent::Viewport message are never used #16809

paulrouget opened this issue May 11, 2017 · 3 comments
Labels
A-gfx/compositing

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 11, 2017

Any reason to keep it?
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 15, 2017

/cc @glennw @meh (introduced in #7552)
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 29, 2017

I think this made sense before webrender.

I will remove this and introduce later a way to specify the position of the viewport.
@paulrouget paulrouget mentioned this issue May 29, 2017
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue May 29, 2017
@bors-servo
Auto merge of #17074 - paulrouget:remove_viewport, r=emilio
Loading status checks…
86dcd53 
remove no-op viewport code

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16809 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no-op code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17074)
<!-- Reviewable:end -->
@paulrouget paulrouget reopened this May 29, 2017
@paulrouget paulrouget mentioned this issue May 30, 2017
Closed
@paulrouget paulrouget mentioned this issue Sep 5, 2017
Open
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jan 26, 2019

Will be taken care of in #21350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-gfx/compositing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

remove no-op viewport code
2 participants
@jdm @paulrouget
You can’t perform that action at this time.