New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor grid style types and impls #16970
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
Heads up! This PR modifies the following files:
|
☔ The latest upstream changes (presumably #16960) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #16973) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Sorry for not looking at this sooner. Ping me once you've rebased and done the changes, and we'll land this :)
} | ||
|
||
impl ComputedValueAsSpecified for GridLine { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: newline not necessary
Ok(()) | ||
} | ||
} | ||
|
||
impl Parse for GridLine { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also move this Parse
impl to generics, since the specified and computed values have the same type anyway.
/// An `<auto-fit>` keyword allowed only for `<auto-repeat>` | ||
AutoFit, | ||
} | ||
|
||
impl Parse for RepeatCount { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This impl too.
AutoFit, | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Please remove this newline.
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: ditto on newline (please check for similar nits)
No worries and thanks for your review @wafflespeanut! |
Thanks for doing this! @bors-servo r+ |
@wafflespeanut: 🔑 Insufficient privileges: Not in reviewers |
|
@wafflespeanut Homu is case-sensitive; did you rename your account recently? @bors-servo: r=wafflespeanut |
📌 Commit 72db176 has been approved by |
@jdm Yeah, I just realized that. r? servo/saltfs#673 |
@bors-servo p=173 |
@wafflespeanut: 🔑 Insufficient privileges: and not in try users |
Great, code hasn't been deployed yet (sigh) |
@bors-servo p=2 |
Refactor grid style types and impls Fixes #16949. - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's just a refactor <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16970) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
Fixes #16949.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is