Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user for URL on Ctrl/Cmd-L #17047

Closed
paulrouget opened this issue May 26, 2017 · 4 comments
Closed

Prompt user for URL on Ctrl/Cmd-L #17047

paulrouget opened this issue May 26, 2017 · 4 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 26, 2017

When the user presses Ctrl-L (or Cmd-L on mac), the glutin port should show a prompt and ask for a new URL.

We should use tinyfiledialogs-rs. Here is an example of how to use a prompt: https://github.com/jdm/tinyfiledialogs-rs/blob/4bf666ab49bf9aafcbbc34b6d4383db00d737654/examples/main.rs#L10

The reload (Ctrl-R) keybinding can be used as an example:

(CMD_OR_CONTROL, Some('r'), _) => {

We should add a rule for Ctrl-L, and if shell.builtin-key-shortcuts.enabled is true, use tinyfiledialogs to ask for a new url (and make the default value of the dialog the current url).

Once this is done, the url can be sanitize (can be done in a follow-up).

And then tell Servo to load this url with WindowEvent::LoadUrl(input).

@jklepatch
Copy link
Contributor

@jklepatch jklepatch commented May 26, 2017

Happy to work on that :)

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented May 26, 2017

@jklepatch thanks. Let me know if you need help.

@jklepatch jklepatch mentioned this issue May 27, 2017
3 of 4 tasks complete
@jdm jdm added A-embedding A-input and removed C-assigned labels Nov 15, 2017
@atouchet
Copy link
Contributor

@atouchet atouchet commented Mar 5, 2018

Can this be closed now?

@jdm
Copy link
Member

@jdm jdm commented Mar 5, 2018

Yep!

@jdm jdm closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.