Key events involving the control key don't work as expected

[paulrouget]

We realized that no keybindings on Windows work (the "reload"/Ctrl-R binding doesn't work for example).

This is because Glutin sends 2 things:

• the character matching the keyboard layout (ReceivedCharacter(ch))
• the key code and modifiers (KeyboardInput)

But the character that is sent when the Ctrl key is pressed is a different unicode character.
For exemple, Ctrl-L will send the "Form Feed" \u{c} character, not L.

A possible approach is to map the key code to the character. This is what is done in the DOM code here:

servo/components/script/dom/keyboardevent.rs

Line 169 in 985050d

Cow::from(match key {

But this is wrong because the event's key property is not localized.

Another approach is to map the combo unicode character to its original key. For example:

'\u{c}' => 'l',
'\u{12}' => 'r',
…

Both the ports/glutin/window.rs and components/script/dom/keyboardevent.rs need this.

[jklepatch]

I am working on this

[atouchet]

Is #16459 related to this issue?

[paulrouget]

Is #16459 related to this issue?

Very likely, yes.

[atouchet]

@paulrouget do you know what the current situation is regarding this issue? As far as I can tell control key input still isn't working properly after the Glutin update.

[paulrouget]

We need to investigate see if that needs to be fixed in glutin or in servo.

[atouchet]

@paulrouget I've been testing your PR for this and it works somewhat but there are still some definite issues. On first launch using Ctrl + L to open the URL dialog works consistently but subsequent attempts at doing this (ex. load servo.org homepage -> press Ctrl + L to navigate to new page -> press Ctrl + L again to navigate to another new page) do not bring up the dialog again. It seems to work only once and then rarely or not at all afterwards. Should I file a new issue for this behaviour?

Edit: It's actually easier than that to reproduce. You can just exit the dialog box after bringing it up with Ctrl + L and you won't be able to bring up back up again easily.

Edit 2: I've now been able to bring up the URL dialog without even pressing Ctrl and L at the same time at one point. There's definitely something off here.

[paulrouget]

Should I file a new issue for this behaviour?

Yes please.

Thanks!