Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about:failure doesn't exist any more #17187

Closed
Tracked by #30251
jdm opened this issue Jun 6, 2017 · 2 comments · Fixed by #30290
Closed
Tracked by #30251

about:failure doesn't exist any more #17187

jdm opened this issue Jun 6, 2017 · 2 comments · Fixed by #30290

Comments

@jdm
Copy link
Member

jdm commented Jun 6, 2017

This disappeared along with the pre-fetch network stack; now basic_fetch only checks for about:blank. This explains why we sometimes end up seeing "Unexpected scheme" error pages.

@delan
Copy link
Sponsor Member

delan commented Aug 31, 2023

Adding a case for about:failure to scheme_fetch in components/net/fetch/methods.rs should get us most of the way, though ideally we want to have a reload button and/or keep the location bar pointing to the original url.

Chrome’s behaviour:

image

@delan
Copy link
Sponsor Member

delan commented Sep 4, 2023

  • we navigate to about:failure without replacing, which trashes the forward history
  • even if we navigated with replacement, we would trash the original url and LoadData
  • we should instead “reload” the page to a synthesized error page like BadCertHTML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants