Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on an ordering convention for imports #172

Closed
burg opened this issue Nov 6, 2012 · 2 comments
Closed

Decide on an ordering convention for imports #172

burg opened this issue Nov 6, 2012 · 2 comments

Comments

@burg
Copy link

@burg burg commented Nov 6, 2012

It's probably a good time to declare a house style, so that it's easier to tell what imports come from where (other crates, libcore/libstd, or same crate).

I propose using one of the following orders (with each subsection alphabetized):

Top-down

  • extern mod statements
  • libcore/libstd
  • other crates
  • this crate

Bottom-up

  • extern mod statements
  • this crate
  • other crates
  • libcore/libstd
@brson
Copy link
Contributor

@brson brson commented Nov 6, 2012

I've been itching for a style guide in general. For this (and most things) I prefer top down. This really needs tool support since it's tedious to do, and hard to maintain and enforce.

@burg
Copy link
Author

@burg burg commented Apr 17, 2013

@burg burg closed this Apr 17, 2013
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Compute local uv coordinates after vertex shader clipping rather than before it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.