Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The build tool passes -vv to cargo as -v #17231

Closed
yarwelp opened this issue Jun 8, 2017 · 1 comment
Closed

The build tool passes -vv to cargo as -v #17231

yarwelp opened this issue Jun 8, 2017 · 1 comment
Labels
A-mach L-python

Comments

@yarwelp
Copy link

@yarwelp yarwelp commented Jun 8, 2017 •
edited

Running ./mach build -d -j 1 -vv executes cargo build -j 1 -v when IMO it should execute cargo build -j 1 -vv.
CodenameLambda added a commit to CodenameLambda/servo that referenced this issue Jun 8, 2017
@CodenameLambda
Fix for issue servo#17231
1a9c147 
This change fixes the issue servo#17231 (passing `-vv` to `./mach build ...` only passes `-v` to `cargo`).

But this introduces another pontential issue, as you can now pass `-vv` and `-v` at the same time. But I do not expect this to be a real problem, especially since `cargo` doesn't care.
CodenameLambda added a commit to CodenameLambda/servo that referenced this issue Jun 8, 2017
@CodenameLambda
Create build_commands.py
0a6b893 
This change fixes the issue servo#17231 (passing `-vv` to `./mach build ...` only passes `-v` to `cargo`).

But this introduces another pontential issue, as you can now pass `-vv` and `-v` at the same time. But I do not expect this to be a real problem, especially since `cargo` doesn't care.
@CodenameLambda CodenameLambda mentioned this issue Jun 8, 2017
Closed
4 of 5 tasks complete
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 7, 2017

Latest attempt at #17237, which has some comments that needs to be addressed.
@tigercosmos tigercosmos mentioned this issue Dec 23, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
11a25e3 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
23351f0 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
7c07f31 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

pass -vv through mach to cargo
Pass -vv through mach to cargo
3 participants
@nox @yarwelp @KiChjang
You can’t perform that action at this time.