Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share styles for elements with eager pseudo-elements attached to them #17245

Merged
merged 1 commit into from Jun 8, 2017
Merged

Share styles for elements with eager pseudo-elements attached to them #17245

merged 1 commit into from Jun 8, 2017

Conversation

bzbarsky
Copy link
Contributor

@bzbarsky bzbarsky commented Jun 8, 2017 •
edited by larsbergstrom

  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented Jun 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/data.rs, components/style/sharing/mod.rs, components/style/sharing/checks.rs
  • @emilio: components/style/data.rs, components/style/sharing/mod.rs, components/style/sharing/checks.rs

@highfive
Copy link

highfive commented Jun 8, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 8, 2017
@bzbarsky
Copy link
Contributor Author

bzbarsky commented Jun 8, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 9110241 has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Jun 8, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 8, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 9110241 with merge 310408a...

bors-servo pushed a commit that referenced this pull request Jun 8, 2017
Auto merge of #17245 - bzbarsky:share-pseudo-styles, r=emilio
310408a 
Share styles for elements with eager pseudo-elements attached to them

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1329361

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17245)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 310408a to master...

@bors-servo bors-servo merged commit 9110241 into servo:master Jun 8, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bzbarsky @highfive @bors-servo @emilio @cbrewster