stylo: Support :active and :hover quirk #17266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r=bholley,emilio |
|
📌 Commit 124290f has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 10, 2017
stylo: Support :active and :hover quirk Reviewed by bholley and emilo on the bugzilla bug. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1355724](https://bugzilla.mozilla.org/show_bug.cgi?id=1355724) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17266) <!-- Reviewable:end -->
|
@bors-servo r- |
|
💔 Test failed - linux-dev |
highfive
added
S-tests-failed
emilio
reviewed
Jun 10, 2017
components/selectors/matching.rs
Outdated
| !negated.iter().all(|ss| matches_simple_selector(ss, element, context, relevant_link, flags_setter)) | ||
| let old_value = context.within_functional_pseudo_class_argument; | ||
| context.within_functional_pseudo_class_argument = true; | ||
| let result = !negated.iter().all(|ss| matches_simple_selector(ss, element, context, |
There was a problem hiding this comment.
nit: Please add braces and move the function call to its own line, or indent the arguments (though preferably the first).
emilio
reviewed
Jun 10, 2017
components/selectors/parser.rs
Outdated
| @@ -103,6 +103,11 @@ macro_rules! with_all_bounds { | |||
|
|
|||
| /// pseudo-elements | |||
| type PseudoElement: $($CommonBounds)* + PseudoElement<Impl = Self>; | |||
|
|
|||
| /// Returns whether the selector matches conditions for the :active and | |||
| /// :hover quirk. | |||
There was a problem hiding this comment.
Also, this comment is false, this only returns whether the pseudo-class is :hover or :active, right?
There was a problem hiding this comment.
Ah, this method changed so many times and I forgot to change the comment at some point :)
emilio
reviewed
Jun 10, 2017
components/style/gecko/wrapper.rs
Outdated
| // NB: It's important to use `intersect` instead of `contains` | ||
| // here, to handle `:any-link` correctly. | ||
| /// FIXME: This can/should probably be contains() now that any-link | ||
| // (which depends in multiple bits) is handled in its own case below. |
There was a problem hiding this comment.
Intersect is fine, you can remove or revert the comment.
It was getting inial value from gecko side before and that was always eCompatibility_NavQuirks. Created an FFI to fetch quirks mode.
canova
force-pushed
the
active_hover_quirk
branch
from
124290f
to
309531e
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=bholley,emilio |
|
📌 Commit 309531e has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 10, 2017
stylo: Support :active and :hover quirk Reviewed by bholley and emilo on the bugzilla bug. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1355724](https://bugzilla.mozilla.org/show_bug.cgi?id=1355724) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17266) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by bholley and emilo on the bugzilla bug.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is