Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text highlighting doesn't respect scrolling below the fold #17327

Open
jonathandturner opened this issue Jun 14, 2017 · 8 comments
Open

Text highlighting doesn't respect scrolling below the fold #17327

jonathandturner opened this issue Jun 14, 2017 · 8 comments

Comments

@jonathandturner
Copy link

@jonathandturner jonathandturner commented Jun 14, 2017

This seems similar to the issue with had with click areas not respecting scrolling (#16504 and #16405). If you scroll down the page and try to highlight some text, it will ignore that you've scrolls and highlight text as if you were still above the fold.

Here's an example of me scrolling down the page and highlighting starting with the "0 =>"

screen shot 2017-06-15 at 10 45 48

@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Jun 15, 2017

Note: Text highlighting with mouse is not supported in servo yet. (At least it does not work for me.) The code example uses the Ace editor which somehow (probably servo sends wrong position) highlights the wrong text sections.

@jdm
Copy link
Member

@jdm jdm commented Jun 15, 2017

It would be worth checking if this is reproducible using a regular textbox.

@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Jun 15, 2017

Since regular textboxes do not support highlighting yet: No it isn't. See issue #10083

There are weird things going on with positions and scrolling but they also happen with regular divs.

@jdm
Copy link
Member

@jdm jdm commented Jun 15, 2017

Highlighting is supported by the keyboard, not the mouse.

@jonathandturner
Copy link
Author

@jonathandturner jonathandturner commented Jun 20, 2017

@jdm - if that's true, sounds like we'd want to disable the mouse highlight until it's working

@jdm
Copy link
Member

@jdm jdm commented Jun 20, 2017

You cannot highlight things with the mouse, so I'm not sure what you're suggesting.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Dec 8, 2019

This is still an issue. For reference the page used in the example has moved to: https://prev.rust-lang.org/en-US/

@jdm
Copy link
Member

@jdm jdm commented Dec 9, 2019

This may be related to events having incorrect clientX/clientY values, based on reading the unminified ACE editor code from https://cdn.jsdelivr.net/ace/1.1.3/noconflict/ace.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.