Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPaint worklets: "concrete object size" #17376
Closed
Assignees
Comments
|
Spec issue: w3c/css-houdini-drafts#417 |
bors-servo
added a commit
that referenced
this issue
Jun 22, 2017
Paint worklet size should agree with Chrome. <!-- Please describe your changes on the following line: --> Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17376 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17456) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec for "draw a paint image" (https://drafts.css-houdini.org/css-paint-api/#draw-a-paint-image) is defined in terms of the "concrete object size" (https://drafts.csswg.org/css-images-3/#concrete-object-size). We should make sure a) we're doing the right thing, and b) we're doing the same as Chrome, hopefully both.