Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested requestAnimationFrame not being fired if reftest-wait is set #17408

Closed
asajeffrey opened this issue Jun 19, 2017 · 1 comment
Closed

Nested requestAnimationFrame not being fired if reftest-wait is set #17408

asajeffrey opened this issue Jun 19, 2017 · 1 comment
Labels
A-content/script A-layout/animations

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 19, 2017

A minimal example:

<html class="reftest-wait">
  <script>
    console.log("A"); 
    requestAnimationFrame(function() {
      console.log("B");
      requestAnimationFrame(function() {
        console.log("C");
        document.documentElement.classList.remove("reftest-wait");
      });
    });
 </script>
</html>

produces:

$ ./mach run -d -x test.html 
A
B
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jun 19, 2017

IRC chat with @jdm: http://logs.glob.uno/?c=mozilla%23servo&s=19+Jun+2017&e=19+Jun+2017#c701330
@asajeffrey asajeffrey mentioned this issue Jun 19, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jun 19, 2017
@bors-servo
Auto merge of #17410 - asajeffrey:compositor-nested-rAF-with-reftest-…
Loading status checks…
a9e0109 
…wait, r=jdm

Support nested requestAnimationFrame in the presence of reftest-wait

<!-- Please describe your changes on the following line: -->

Currently, nested rAF callbacks don't get called in the presence of reftest-wait. This PR fixes that.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17408
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17410)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 19, 2017
@bors-servo
Auto merge of #17410 - asajeffrey:compositor-nested-rAF-with-reftest-…
Loading status checks…
5f10a25 
…wait, r=jdm

Support nested requestAnimationFrame in the presence of reftest-wait

<!-- Please describe your changes on the following line: -->

Currently, nested rAF callbacks don't get called in the presence of reftest-wait. This PR fixes that.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17408
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17410)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script A-layout/animations
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Support nested requestAnimationFrame in the presence of reftest-wait
1 participant
@asajeffrey
You can’t perform that action at this time.