Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requestAnimationFrame callback execution easier to reason about #17423

Open
jdm opened this issue Jun 20, 2017 · 0 comments
Open

Make requestAnimationFrame callback execution easier to reason about #17423

jdm opened this issue Jun 20, 2017 · 0 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 20, 2017

#17398 works around a problem where our short-circuiting layout behaviour gets in the way of our animation callbacks. When layout does not run, it does not generate a frame for the compositor, so the compositor code does not have a chance schedule further animation callbacks. The solution in that PR is to force a real layout to occur in this case, which is self-contained but not great. I see two possible alternatives:

  • make layout operations for requestAnimationFrame impossible to short-circuit
  • make the compositor schedule the animation callbacks independently of the actual compositing operation in headless mode
@jdm jdm changed the title Make layout operations for requestAnimationFrame always occur Make requestAnimationFrame callback execution easier to reason about Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.