Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paint worklets: implement input arguments #17435

Closed
asajeffrey opened this issue Jun 20, 2017 · 0 comments
Closed

Paint worklets: implement input arguments #17435

asajeffrey opened this issue Jun 20, 2017 · 0 comments
Assignees
@asajeffrey
Labels
A-content/css A-content/script

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 20, 2017

Spec: https://drafts.css-houdini.org/css-paint-api/#document-paint-definition-input-argument-syntaxes and https://drafts.css-houdini.org/css-paint-api/#ref-for-document-paint-definition-input-argument-syntaxes-3

Causing a couple of WPT reftest failures:

  ▶ FAIL [expected PASS] /css-paint-api/paint-arguments.html
  └   → /css-paint-api/paint-arguments.html 84fa762299f9e10c088a87d1603218505533bb41
/css-paint-api/paint-arguments-ref.html 063e7586ef816b736e273be3d254e2ca09f8632a
Testing 84fa762299f9e10c088a87d1603218505533bb41 == 063e7586ef816b736e273be3d254e2ca09f8632a

  ▶ FAIL [expected PASS] /css-paint-api/paint-function-arguments.html
  └   → /css-paint-api/paint-function-arguments.html cf010e95a3ae0bda2d250c1cfb1004d264f93060
/css-paint-api/paint-function-arguments-ref.html 1f2a1fac239a8c3e14c66d57ef1a7ae1282af791
Testing cf010e95a3ae0bda2d250c1cfb1004d264f93060 == 1f2a1fac239a8c3e14c66d57ef1a7ae1282af791
@asajeffrey asajeffrey self-assigned this Jun 20, 2017
@asajeffrey asajeffrey mentioned this issue Jun 28, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 29, 2017
@bors-servo
Auto merge of #17546 - asajeffrey:script-paint-worklets-arguments, r=…
Loading status checks…
097e36b 
…emilio

Script paint worklets arguments

<!-- Please describe your changes on the following line: -->

Implement paint worklet arguments.

This is a dependent PR, only the last commit is in this PR.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17435
- [X] These changes do not require tests because there are tests in the most recent wpt.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17546)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-content/css A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Script paint worklets arguments
1 participant
@asajeffrey
You can’t perform that action at this time.