Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low quality "Build on GitHub" icons #17465

Open
atouchet opened this issue Jun 22, 2017 · 3 comments
Open

Low quality "Build on GitHub" icons #17465

atouchet opened this issue Jun 22, 2017 · 3 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Jun 22, 2017

From the "Build on GitHub" section of the GitHub homepage. The icons look noticeably worse in Servo than in other browsers. Also strangely they appear to be slightly off-centre as well. Possibly the same issue as #11960.

Image of the issue (Firefox top, Servo bottom):

Icon comparison

Tested in Windows 10.

@jdm
Copy link
Member

@jdm jdm commented Jun 22, 2017

@glennw Could this be an issue in WR?

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Jun 22, 2017

There is a second example of this issue on https://github.com/features as well.

Edit: There are a number of examples throughout GitHub.

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Mar 2, 2018

Icon comparison
Click for full resolution.

This is slightly improved in the latest nightly build but most of the icons are still bad looking. The only one that is noticeably different is Codeship and that now looks blurrier than in Firefox. @glennw is this due to servo/webrender#2408? I noticed that Codeship is the only icon there larger than 512 x 512 (https://assets-cdn.github.com/images/modules/site/integrators/codeship.png).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.