Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar on Hacker News too large #17513

Closed
atouchet opened this issue Jun 24, 2017 · 4 comments
Closed

Top bar on Hacker News too large #17513

atouchet opened this issue Jun 24, 2017 · 4 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Jun 24, 2017

The top orange bar on Hacker News is longer in Servo than in other browsers. Servo has it as 33 pixels tall while in other browsers it is 24 pixels. There is also additional space around the Hacker News icon in Servo (2 additional pixels on the top and left, 5 on the bottom). Finally in Servo the Hacker News icon is shown as being 20 x 20 rather than 18 x 18.

In Servo:

Servo bar

In Firefox:

Firefox bar

Tested in Windows 10.

@atouchet atouchet mentioned this issue Jun 24, 2017
3 of 6 tasks complete
@emilio
Copy link
Member

@emilio emilio commented Jun 25, 2017

I believe this is #14947

@jdm
Copy link
Member

@jdm jdm commented Jun 25, 2017

That comment thread leads us to #11704 (comment) as the real culprit.

@adamncasey
Copy link
Contributor

@adamncasey adamncasey commented Aug 15, 2017

#12609 will also help out here

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Aug 15, 2017

This is probably a duplicate of #11821.

@atouchet atouchet closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.