New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script paint worklets arguments #17546
Script paint worklets arguments #17546
Conversation
Heads up! This PR modifies the following files:
|
☔ The latest upstream changes (presumably #17239) made this pull request unmergeable. Please resolve the merge conflicts. |
8094f68
to
ed11958
Compare
☔ The latest upstream changes (presumably #17326) made this pull request unmergeable. Please resolve the merge conflicts. |
ed11958
to
862bdc2
Compare
This PR's dependencies merged, so it's ready for review. |
☔ The latest upstream changes (presumably #17606) made this pull request unmergeable. Please resolve the merge conflicts. |
862bdc2
to
e8b6bd6
Compare
☔ The latest upstream changes (presumably #17499) made this pull request unmergeable. Please resolve the merge conflicts. |
dc678e8
to
335c4c1
Compare
☔ The latest upstream changes (presumably #17634) made this pull request unmergeable. Please resolve the merge conflicts. |
335c4c1
to
042c894
Compare
☔ The latest upstream changes (presumably #17868) made this pull request unmergeable. Please resolve the merge conflicts. |
752e279
to
2f177b9
Compare
let name = paint_worklet.name.clone(); | ||
let arguments = paint_worklet.arguments.iter() | ||
.map(|argument| argument.to_css_string()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kinda unfortunate... but I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be nice to serialize something better than a String, but I'm not sure what that would be :/
2f177b9
to
d101f9c
Compare
Squashed. @bors-servo r=emilio |
📌 Commit d101f9c has been approved by |
…emilio Script paint worklets arguments <!-- Please describe your changes on the following line: --> Implement paint worklet arguments. This is a dependent PR, only the last commit is in this PR. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17435 - [X] These changes do not require tests because there are tests in the most recent wpt. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17546) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
Implement paint worklet arguments.
This is a dependent PR, only the last commit is in this PR.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is