Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script paint worklets arguments #17546

Merged
merged 1 commit into from Jul 29, 2017

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 28, 2017

Implement paint worklet arguments.

This is a dependent PR, only the last commit is in this PR.


This change is Reviewable

@asajeffrey asajeffrey added A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-content/script Related to the script thread labels Jun 28, 2017
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo/restyle_damage.rs, components/style/values/specified/image.rs, components/style/values/generics/image.rs
  • @KiChjang: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
  • @fitzgen: components/script/dom/webidls/PaintWorkletGlobalScope.webidl, components/script/dom/webidls/StylePropertyMapReadOnly.webidl, components/script_layout_interface/lib.rs, components/script/dom/testworkletglobalscope.rs, components/script/dom/mod.rs and 23 more
  • @emilio: components/layout/display_list_builder.rs, components/style/servo/restyle_damage.rs, components/layout/context.rs, components/layout/Cargo.toml, components/layout/lib.rs and 2 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 28, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17239) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jun 30, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from 8094f68 to ed11958 Compare June 30, 2017 20:44
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17326) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jun 30, 2017
@nox nox added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Jul 5, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from ed11958 to 862bdc2 Compare July 17, 2017 16:32
@asajeffrey asajeffrey removed S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. S-needs-rebase There are merge conflict errors. labels Jul 17, 2017
@asajeffrey
Copy link
Member Author

This PR's dependencies merged, so it's ready for review.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17606) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jul 17, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from 862bdc2 to e8b6bd6 Compare July 17, 2017 21:33
@asajeffrey asajeffrey removed the S-needs-rebase There are merge conflict errors. label Jul 18, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17499) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jul 21, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from dc678e8 to 335c4c1 Compare July 21, 2017 21:26
@asajeffrey asajeffrey removed the S-needs-rebase There are merge conflict errors. label Jul 21, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17634) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jul 21, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from 335c4c1 to 042c894 Compare July 24, 2017 19:38
@asajeffrey asajeffrey added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-needs-rebase There are merge conflict errors. labels Jul 24, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #17868) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jul 26, 2017
@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from 752e279 to 2f177b9 Compare July 28, 2017 19:21
@asajeffrey asajeffrey removed the S-needs-rebase There are merge conflict errors. label Jul 28, 2017
let name = paint_worklet.name.clone();
let arguments = paint_worklet.arguments.iter()
.map(|argument| argument.to_css_string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda unfortunate... but I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be nice to serialize something better than a String, but I'm not sure what that would be :/

@asajeffrey asajeffrey force-pushed the script-paint-worklets-arguments branch from 2f177b9 to d101f9c Compare July 29, 2017 20:32
@asajeffrey
Copy link
Member Author

Squashed. @bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit d101f9c has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-squash Some (or all) of the commits in the PR should be combined. labels Jul 29, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d101f9c with merge 097e36b...

bors-servo pushed a commit that referenced this pull request Jul 29, 2017
…emilio

Script paint worklets arguments

<!-- Please describe your changes on the following line: -->

Implement paint worklet arguments.

This is a dependent PR, only the last commit is in this PR.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17435
- [X] These changes do not require tests because there are tests in the most recent wpt.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17546)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 097e36b to master...

@bors-servo bors-servo merged commit d101f9c into servo:master Jul 29, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-content/script Related to the script thread
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paint worklets: implement input arguments
5 participants