Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StylePropertyMap.getProperties() #17579

Closed
asajeffrey opened this issue Jun 30, 2017 · 1 comment
Closed

Implement StylePropertyMap.getProperties() #17579

asajeffrey opened this issue Jun 30, 2017 · 1 comment
Assignees
@asajeffrey
Labels
A-content/css A-content/script

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 30, 2017

It's causing a couple of test failures with web-platform-tests/wpt#6439:

  ▶ FAIL [expected PASS] /css-paint-api/style-before-pseudo.html
  └   → /css-paint-api/style-before-pseudo.html 4865384d01eea059c49148a14da716c983db113c
/css-paint-api/style-before-pseudo-ref.html 48f958380841207304b50a666042e2228c633bc8
Testing 4865384d01eea059c49148a14da716c983db113c == 48f958380841207304b50a666042e2228c633bc8

  ▶ FAIL [expected PASS] /css-paint-api/style-first-letter-pseudo.html
  └   → /css-paint-api/style-first-letter-pseudo.html 2ea478597decb50de1fd5560af3583de12ebba6e
/css-paint-api/style-first-letter-pseudo-ref.html 31220c639cef4b5b0e91fd4111263526b9291d71
Testing 2ea478597decb50de1fd5560af3583de12ebba6e == 31220c639cef4b5b0e91fd4111263526b9291d71
@asajeffrey asajeffrey self-assigned this Jun 30, 2017
@asajeffrey asajeffrey mentioned this issue Jul 17, 2017
Open
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jul 25, 2017

Slightly annoyingly, these tests also fail because of #17854.
@asajeffrey asajeffrey mentioned this issue Jul 25, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Aug 7, 2017
@bors-servo
Auto merge of #17855 - asajeffrey:script-implement-more-styleproperty…
Loading status checks…
b07f06c 
…maypreadonly, r=emilio

Implement getProperties for StylePropertyMapReadOnly

<!-- Please describe your changes on the following line: -->

Implement `getProperties` for `StylePropertyMapReadOnly`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17579.
- [X] These changes do not require tests because the existing css-paint-api tests catch this (rather annoyingly, they all fail for different reasons, sigh)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17855)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-content/css A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement getProperties for StylePropertyMapReadOnly
1 participant
@asajeffrey
You can’t perform that action at this time.