Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Z show-parallel-layout implementation accidentally deleted #17582

Open
metajack opened this issue Jun 30, 2017 · 3 comments
Open

-Z show-parallel-layout implementation accidentally deleted #17582

metajack opened this issue Jun 30, 2017 · 3 comments
Labels
A-gfx/displaylist

Comments

@metajack
Copy link
Contributor

@metajack metajack commented Jun 30, 2017

It appears at some point the code that built an altered display list when -Z show-parallel-layout was given got deleted, and we should bring it back.
@metajack
Copy link
Contributor Author

@metajack metajack commented Jun 30, 2017

cc @mihajlija
@jdm
Copy link
Member

@jdm jdm commented Jul 7, 2017

This is supposed to happen through build_display_items_for_debugging_tint which is called from build_display_list_for_block and build_display_list_for_inline. I am confused why this is not working, since we set the option in from_cmdline_args.
@jdm
Copy link
Member

@jdm jdm commented Jul 7, 2017

The display list is definitely altered when I use -Z show-parallel-layout, but there's no tinting, just borders that are all the same colours for all elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-gfx/displaylist
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @metajack
You can’t perform that action at this time.