Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigationStart value is incorrect #17651

Closed
jdm opened this issue Jul 10, 2017 · 0 comments
Closed

navigationStart value is incorrect #17651

jdm opened this issue Jul 10, 2017 · 0 comments
Assignees
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 10, 2017

We currently initialize the value that is returned by PerformanceTiming.navigationStart during ScriptThread::load. This means that it represents the time at which we have already received the initial response from the network. This disagrees with the definition of https://www.w3.org/TR/navigation-timing/#dom-performancetiming-navigationstart.

@jdm jdm added the A-content/dom label Jul 10, 2017
@ferjm ferjm self-assigned this Jul 12, 2017
bors-servo added a commit that referenced this issue Jul 18, 2017
Set navigation start value according to navigation timing spec

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17651

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17735)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.