Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. #17654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
The failure is apparently something to do with LLVM? https://travis-ci.org/servo/servo/jobs/252199331#L2455 |
|
Travis is broken (out of disk space it seems), but it doesn't block landing. |
|
"Bug 1355380 - Part 2: Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles." could use being shortened. |
nox
reviewed
Jul 11, 2017
| fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write { | ||
| match *self { | ||
| Orientation::Angle0 => dest.write_str("0"), | ||
| Orientation::Angle90 => dest.write_str("90"), |
There was a problem hiding this comment.
Yep, thanks for the catch!
and pass orientations directly as an enum instead of as angles. Depends on a Gecko change to be subsequently landed in m-c.
|
@bors-servo r=Manishearth |
|
@jyc: 🔑 Insufficient privileges: Not in reviewers |
|
@bors-servo r=Manishearth |
|
📋 Looks like this PR is still in progress, ignoring approval |
canova
changed the title
|
@bors-servo r+ |
|
📌 Commit e554146 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 11, 2017
Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. Has been reviewed: https://reviewboard.mozilla.org/r/155336/ <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Bugzilla issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1355380 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17654) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
moz-servo-sync
pushed a commit
to moz-servo-sync/servo
that referenced
this pull request
Jul 11, 2017
…test/test_value_computation.html. r=backout Backs out servo#17654
bors-servo
pushed a commit
that referenced
this pull request
Jul 11, 2017
Backed out changeset 3977404931e5 for failing mochitest layout/style/test/test_value_computation.html. r=backout Backed out changeset 3977404931e5 for failing mochitest layout/style/test/test_value_computation.html. r=backout Backs out #17654 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17679) <!-- Reviewable:end -->
|
This was backed out, and I'd like to try it again now that the full try run has passed (https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd689286571af0eb0bcd1ae3255fe4e1a7230c3f)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been reviewed: https://reviewboard.mozilla.org/r/155336/
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsBugzilla issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1355380
This change is