servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextRun creation must account for text render-ability by FontGroup fonts #177

Closed

burg opened this issue Nov 7, 2012 · 1 comment

Labels

A-layout/text A-platform/fonts I-wrong

burg commented Nov 7, 2012

If some text in a text run can't be rendered in the first FontGroup font (say, because of language or missing chars), then the next one must be used. This causes a text run split, because of the one Font per TextRun invariant.

The font group is not presently consulted. It should be built for each style context within an inline flow.

Author

burg commented Nov 12, 2012

The FontGroup::create_textrun method has been added, but it doesn't do anything complicated now. It just assigns the first Font instance in the FontGroup unconditionally.

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue


        Merge pull request servo#177 from ronkorving/submissions/ronkorving

Tests for XHR progress

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

04eb516

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

pcwalton mentioned this issue

layout: Implement per-glyph font fallback. #5607

Merged

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

aafcf7a

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

bors-servo pushed a commit that referenced this issue


        Auto merge of #5607 - pcwalton:per-glyph-font-fallback, r=mbrubeck

05edd87

This improves numerous pages, for example Wikipedia and Ars Technica.

Built on #5493.

Closes #177.

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

1b5a13d

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

bors-servo pushed a commit that referenced this issue


        Auto merge of #5607 - pcwalton:per-glyph-font-fallback, r=glennw

79932d9

This improves numerous pages, for example Wikipedia and Ars Technica.

Built on #5493.

Closes #177.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5607)
<!-- Reviewable:end -->

bors-servo pushed a commit that referenced this issue


        Auto merge of #5607 - pcwalton:per-glyph-font-fallback, r=glennw

d6943f2

This improves numerous pages, for example Wikipedia and Ars Technica.

Built on #5493.

Closes #177.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5607)
<!-- Reviewable:end -->

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

78bc0fa

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

e4bb3a9

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

689a2e5

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

bors-servo pushed a commit that referenced this issue


        Auto merge of #5607 - pcwalton:per-glyph-font-fallback, r=mbrubeck

f13ab73

This improves numerous pages, for example Wikipedia and Ars Technica.

Built on #5493.

Closes #177.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5607)
<!-- Reviewable:end -->

pcwalton added a commit to pcwalton/servo that referenced this issue


        layout: Implement per-glyph font fallback.

fec43b4

This improves numerous pages, for example Wikipedia and Ars Technica.

Closes servo#177.

bors-servo pushed a commit that referenced this issue


        Auto merge of #5607 - pcwalton:per-glyph-font-fallback, r=mbrubeck

7561f7b

This improves numerous pages, for example Wikipedia and Ars Technica.

Built on #5493.

Closes #177.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5607)
<!-- Reviewable:end -->

bors-servo closed this in #5607

glennw pushed a commit to glennw/servo that referenced this issue


        Use stencil buffer for clipping iframes and aabb tree nodes.

29c16a0

(This allows correct clipping for these cases when transforms are involved).

This is a partial fix for servo#177 (the other part relies on changes to layout).

glennw pushed a commit to glennw/servo that referenced this issue


        Handle stacking context transforms when calculating local space clip …

1662a95

…rect.

(For simple cases only, for now).

Fixes servo#177.

jdm mentioned this issue

Crash loading CSS painting #24658

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.