Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement text-emphasis handling #17715
Comments
|
I guess one subtlety is that text-emphasis marks require space so you may need to adjust the whole text's baseline(?) to make room. |
|
Don't assign me yet, but I plan to give it a look. |
|
Hi! Can you assign me? I'm not a contributor yet though |
|
@askalski Have you begun working on this issue? Would it be OK for @NeverHappened to start working on it? |
|
I've done some work on this issue and have questions. Where can I ask them? In IRC? Who should I talk to? |
|
IRC or here are fine choices, especially if you don't end up receiving a response on IRC. |
|
|
|
@NeverHappened Any reason you need to clone the |
|
@mrobinson No, no reason. I have issues because the code for generating display item is in the building display list phase, but the calculating text properties is done long before that. |
https://developer.mozilla.org/en-US/docs/Web/CSS/text-emphasis
The layout code just needs to grab the info from stylo, figure out the positioning of the glyphs, and emit a TextDisplayItem into its DisplayList.
I have marked off where text-emphasis marks should (potentially) be emitted in this PR: #17675.