Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReview usage of .to_lowercase() #17777
Open
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Jul 27, 2017
Audit usages of unicode case-changing methods. Part of #17777. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17883) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 28, 2017
Audit usages of unicode case-changing methods. Part of #17777. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17883) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 28, 2017
Audit usages of unicode case-changing methods. Part of #17777. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17883) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 29, 2017
Audit usages of unicode case-changing methods. Part of #17777. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17883) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Aug 2, 2017
Audit usages of unicode case-changing methods. Part of #17777. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17883) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Aug 2, 2017
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 4dc82b9feba039e3f300ec5884d04ecab21f13e9
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this issue
Aug 3, 2017
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this issue
Aug 3, 2017
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8 UltraBlame original commit: 374c0f030db82ebaff91dda56d02dfb0e1d1b2e7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8 UltraBlame original commit: 374c0f030db82ebaff91dda56d02dfb0e1d1b2e7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…from frewsxcv:frewsxcxv-lowercase); r=SimonSapin Part of servo/servo#17777. Source-Repo: https://github.com/servo/servo Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8 UltraBlame original commit: 374c0f030db82ebaff91dda56d02dfb0e1d1b2e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It does Unicode case mapping, whereas some parts of the web platform that are case-insensitive are only so in the ASCII range. Where appropriate, switch to
.to_ascii_lowercase()instead (withuse std::ascii::AsciiExt;).