Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to bindgen 0.29 #17902

Merged
merged 1 commit into from Jul 28, 2017
Merged

Upgrade to bindgen 0.29 #17902

merged 1 commit into from Jul 28, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Jul 28, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 28, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Jul 28, 2017

@bors-servo r=heycam p=10

@bors-servo
Copy link
Contributor

📌 Commit 193be64 has been approved by heycam

@highfive highfive assigned heycam and unassigned pcwalton Jul 28, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 28, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Jul 28, 2017

We need to update binding files after this get synced to autoland.

@upsuper
Copy link
Contributor Author

upsuper commented Jul 28, 2017

@bors-servo r=heycam p=10

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit 193be64 has been approved by heycam

@bors-servo
Copy link
Contributor

⌛ Testing commit 193be64 with merge 9566f83...

bors-servo pushed a commit that referenced this pull request Jul 28, 2017
Auto merge of #17902 - upsuper:update-bindgen, r=heycam
9566f83 
Upgrade to bindgen 0.29

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17902)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 9566f83 to master...

@bors-servo bors-servo merged commit 193be64 into servo:master Jul 28, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 28, 2017
@upsuper upsuper deleted the update-bindgen branch July 28, 2017 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upsuper @highfive @bors-servo @pcwalton @heycam