Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStyle (even for gecko) depending on webrender #17907
Closed
Assignees
Labels
Comments
|
cc @emilio |
|
IRC conversation with @bzbarsky http://logs.glob.uno/?c=mozilla%23servo&s=28+Jul+2017&e=28+Jul+2017#c722375 |
bors-servo
added a commit
that referenced
this issue
Jul 28, 2017
Make webrender_api a servo-only dependency of style_traits <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 29, 2017
WR multi-document update - try 2 <!-- Please describe your changes on the following line: --> Combines #17892 with the patch to detach style_traits from webrender_api --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17907 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ new logic is added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Change 8c588e8#diff-8236d137a70dfe32ad31a2a1ad70ef60R25 made style_traits depend on webrender_api, even for gecko builds. Should that be an optional servo-only dependency? @kvark?