New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the async HTML Tokenizer on a new thread #17914
Conversation
Heads up! This PR modifies the following files:
|
components/selectors/context.rs
Outdated
@@ -49,6 +49,7 @@ pub enum VisitedHandlingMode { | |||
/// | |||
/// See: https://quirks.spec.whatwg.org/ | |||
#[derive(PartialEq, Eq, Copy, Clone, Hash, Debug)] | |||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given selectors
doesn't have a servo
feature, this is dead code right now. Could you revert the selectors changes?
0f34f4e
to
04c1588
Compare
@bors-servo r+ |
📌 Commit 04c1588 has been approved by |
Run the async HTML Tokenizer on a new thread <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors Follow up for #17565 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17914) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsFollow up for #17565
This change is