Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the async HTML Tokenizer on a new thread #17914

Merged
merged 2 commits into from Jul 29, 2017

Conversation

nikhilshagri
Copy link
Contributor

@nikhilshagri nikhilshagri commented Jul 29, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

Follow up for #17565


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/buildbot_steps.yml
  • @fitzgen: components/script/dom/servoparser/async_html.rs
  • @KiChjang: components/script/dom/servoparser/async_html.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 29, 2017
@nikhilshagri
Copy link
Contributor Author

cc @jdm @nox

@@ -49,6 +49,7 @@ pub enum VisitedHandlingMode {
///
/// See: https://quirks.spec.whatwg.org/
#[derive(PartialEq, Eq, Copy, Clone, Hash, Debug)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given selectors doesn't have a servo feature, this is dead code right now. Could you revert the selectors changes?

@emilio
Copy link
Member

emilio commented Jul 29, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 04c1588 has been approved by emilio

@highfive highfive assigned emilio and unassigned pcwalton Jul 29, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 29, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 04c1588 with merge e87d8af...

bors-servo pushed a commit that referenced this pull request Jul 29, 2017
Run the async HTML Tokenizer on a new thread

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Follow up for #17565

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17914)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing e87d8af to master...

@bors-servo bors-servo merged commit 04c1588 into servo:master Jul 29, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants