Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binding files #17919

Merged
merged 1 commit into from Jul 30, 2017
Merged

Update binding files #17919

merged 1 commit into from Jul 30, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Jul 30, 2017

From tip of autoland.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 30, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@upsuper
Copy link
Contributor Author

upsuper commented Jul 30, 2017

This removes tons of lines from structs binding files, likely because of behavior change mentioned in rust-lang/rust-bindgen#834.

@upsuper
Copy link
Contributor Author

upsuper commented Jul 30, 2017

r? @heycam

@highfive highfive assigned heycam and unassigned glennw Jul 30, 2017
@heycam
Copy link
Contributor

heycam commented Jul 30, 2017

@bors-servo r+

I didn't check the structs file changes closely at all; will just assume if Firefox compiles it's fine.

@bors-servo
Copy link
Contributor

📌 Commit 5c778ee has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 5c778ee with merge 31ecea7...

bors-servo pushed a commit that referenced this pull request Jul 30, 2017
Update binding files

From tip of autoland.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17919)
<!-- Reviewable:end -->
@upsuper
Copy link
Contributor Author

upsuper commented Jul 30, 2017

Firefox doesn't need those files. Only Servo CI needs them. mach build-geckolib seems to work fine at least locally.

@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 30, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Jul 30, 2017

thread 'bindings::root::__bindgen_test_layout_UnionMember_open0_OwningNonNull_open1_nsINode_close1_close0_instantiation' panicked at 'assertion failed: `(left == right)` (left: `8`, right: `16`): Size of template specialization: root :: mozilla :: dom :: UnionMember', /home/servo/buildbot/slave/linux-dev/build/target/geckolib/debug/build/style-50230c48b8c253a8/out/gecko/structs_debug.rs:35456
thread 'bindings::root::__bindgen_test_layout_UnionMember_open0_nsString_close0_instantiation' panicked at 'assertion failed: `(left == right)` (left: `8`, right: `16`): Size of template specialization: root :: mozilla :: dom :: UnionMember', /home/servo/buildbot/slave/linux-dev/build/target/geckolib/debug/build/style-50230c48b8c253a8/out/gecko/structs_debug.rs:35478

Looks like we have some trouble... cc @emilio

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 30, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Jul 30, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit e580b8a has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e580b8a with merge 3ec5fce...

bors-servo pushed a commit that referenced this pull request Jul 30, 2017
Update binding files

From tip of autoland.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17919)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 3ec5fce to master...

@bors-servo bors-servo merged commit e580b8a into servo:master Jul 30, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 30, 2017
@upsuper upsuper deleted the update-bindings branch July 30, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants