Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHappy face is missing #17963
Happy face is missing #17963
Comments
|
This may be an effect of this error from the terminal: |
|
I've confirmed that is coming from this line: https://github.com/Valve/fingerprintjs/blob/master/fingerprint.js#L283 so this is related to the |
|
Servo does not implement the canvas text APIs yet: #11681. |
Implement CanvasRenderingContext2d.fillText's "unimplemented" message Basic skeleton for implementing CanvasRenderingContext2d.fillText, only adding methods and parameters in the right place, and a basic test, with some `println!()`. <!-- Please describe your changes on the following line: --> This is only the beginning. It were my first couple of hours looking at Rust and Servo. However, I have _no clue_ how to get the text to render now (basically go from the `println!()` to something else). It's also possible I messed something up with the `DOMString.parse()` but not entirely sure. I'm doing this PR as a starting point to get help and learn more about this, _or_ at least maybe save someone some time while implementing this, if no one's able to take the time and show me where/how. Because it's still a work-in-progress, I'm leaving the boxes below unchecked (even though there are no errors). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #11681 and #17963 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18020) <!-- Reviewable:end -->
|
Was this supposed to have been fixed in #18020? I am still able to reproduce the issue. |
|
It was not @atouchet , it's only not throwing a JS exception anymore with that, which fixes other kinds of problems that weren't in issues, I believe. |
|
The happy face appears to show up now: |
|
Delightful! |
https://qsurvey.mozilla.com/s3/FirefoxInput/#sad