Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't clean C++ submodules by default #180
Comments
|
|
|
Do we aspire to follow GNU conventions? It's ok to have local variations so long as known -- the trouble comes when someone has a stale submodule and doesn't know to use '-er' or '-all' :-/. /be |
|
Is there a good summary of these conventions somewhere? I'm not familiar. |
|
http://www.gnu.org/prep/standards/html_node/Standard-Targets.html Looks like mostlyclean might be the GNU-standard target to use that leaves the sub-modules intact. /be |
|
What does SM, Gecko, etc do in this situation? I'm afraid that even fewer people would guess |
|
SM and Gecko use autoconf213 and have clean distclean and other targets (some grandfathered and not in GNU's conventions, e.g. clobber). My point is not what people would guess, it's what people likely expect from nearby projects with make target conventions. Guessing is not going to work well here anyway. If we have a new circumstance that favors a longer target for "reallyclean", perhaps it is worth breaking with convention(s). There are so many to break from ;-). /be |
|
For now, i've implemented |
Tests for Page Visibility
Use stencil buffer for clipping iframes and aabb tree nodes.
Accidentally cleaning mozjs or skia can cost a few minutes of your time. I will add a list of slow submodules to clean.mk, which will be skipped by
make cleanbut not bymake clean-all.