Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clean C++ submodules by default #180

Closed
burg opened this issue Nov 7, 2012 · 7 comments
Closed

Don't clean C++ submodules by default #180

burg opened this issue Nov 7, 2012 · 7 comments

Comments

@burg
Copy link

@burg burg commented Nov 7, 2012

Accidentally cleaning mozjs or skia can cost a few minutes of your time. I will add a list of slow submodules to clean.mk, which will be skipped by make clean but not by make clean-all.

@jdm
Copy link
Member

@jdm jdm commented Nov 7, 2012

make cleaner

@BrendanEich
Copy link

@BrendanEich BrendanEich commented Nov 7, 2012

Do we aspire to follow GNU conventions? It's ok to have local variations so long as known -- the trouble comes when someone has a stale submodule and doesn't know to use '-er' or '-all' :-/.

/be

@burg
Copy link
Author

@burg burg commented Nov 7, 2012

Is there a good summary of these conventions somewhere? I'm not familiar.

@BrendanEich
Copy link

@BrendanEich BrendanEich commented Nov 7, 2012

http://www.gnu.org/prep/standards/html_node/Standard-Targets.html
ftp://ftp.gnu.org/pub/old-gnu/Manuals/make-3.79.1/html_chapter/make_14.html

Looks like mostlyclean might be the GNU-standard target to use that leaves the sub-modules intact.

/be

@burg
Copy link
Author

@burg burg commented Nov 8, 2012

What does SM, Gecko, etc do in this situation? I'm afraid that even fewer people would guess mostlyclean than cleaner or clean-all.

@BrendanEich
Copy link

@BrendanEich BrendanEich commented Nov 8, 2012

SM and Gecko use autoconf213 and have clean distclean and other targets (some grandfathered and not in GNU's conventions, e.g. clobber).

My point is not what people would guess, it's what people likely expect from nearby projects with make target conventions. Guessing is not going to work well here anyway.

If we have a new circumstance that favors a longer target for "reallyclean", perhaps it is worth breaking with convention(s). There are so many to break from ;-).

/be

@burg
Copy link
Author

@burg burg commented Nov 9, 2012

For now, i've implemented clean-fast as the expedited option, while clean blows away everything.

@burg burg closed this Nov 9, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Use stencil buffer for clipping iframes and aabb tree nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.