Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork rust-xcb #18044

Closed
SimonSapin opened this issue Aug 11, 2017 · 4 comments
Closed

Unfork rust-xcb #18044

SimonSapin opened this issue Aug 11, 2017 · 4 comments

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 11, 2017

At the moment, upgrading Rust in Servo is blocked on rtbo/rust-xcb#40 because the compiler started rejected code that is used to accept (though I arguably shouldn’t have accepted it in the first place): rust-lang/rust#43567. However, the maintainer seems unresponsive at the moment. To unblock I’m going to fork this crate and use it with [patch] in Cargo.toml. Hopefully this is temporary.

This is a tracking issue for eventually getting a fix upstream and revert to using that crate from crates.io.

@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Aug 11, 2017

rtbo/rust-xcb#41 has the start of a fix but is incomplete. I fiddled with the code generation script a bit but didn’t manage to get it to generate something that compiles on Nightly.

@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Aug 11, 2017

@SimonSapin SimonSapin changed the title Unfork/unvendor rust-xcb Unfork rust-xcb Aug 11, 2017
@jdm
Copy link
Member

@jdm jdm commented Aug 17, 2017

It is no longer in use.

@jdm jdm closed this Aug 17, 2017
@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Aug 17, 2017

Oops, I forgot to close this. Thanks.

@ rtbo responded with a proper fix to rtbo/rust-xcb#40 and published version 0.7.7 before #18046 landed, so we ended up never landing the use of this fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.