Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall/build on Windows 10 not working #18055
Comments
|
It is no longer detecting it as an msvc environment for some reason ( |
|
Deleted Visual Studio and then reinstalled it, |
|
Now im getting "linking with 'link.exe' failed: exit code: 1181 |
|
Maybe https://users.rust-lang.org/t/problems-with-installing-rust-on-windows/9349/9 has some suggestions? |
|
Just tried the solutions mentioned in there, its gone back to not knowing the architecture again :( |
|
When i print out the host_triple() i get @jdm looks like ive found the bug, Edit: |
|
Ok in the end i selected |
|
I have done previous steps and I get the same problem :( |
|
@tigercosmos select the windows 10 SDK in the individual components, and try again. The readme needs a serious update |
|
I have installed windows 10 SDK, and try two version SDK. Still not work. I think the problem is not SDK. |
|
@tigercosmos I think ill take a screenshot of what i have installed, when im back on my windows machine, and we can go through the differences. On top of visual studio, i think i also downloaded http://landinghub.visualstudio.com/visual-cpp-build-tools |
|
@Jayflux I have intalled Visual C++ 2015 Build Tools at the beginning. The issue: This problem can fixed by modify function Then, it can find |
|
@tigercosmos i had this problem, i had to set PLATFORM: X64 in my environment variables. Could you check that its set? I think at one point VC would set this but its not being set now and its a manual process. https://github.com/servo/servo/blob/master/python/servo/util.py#L57 |
|
@Jayflux I think the |
|
When I pass |
|
As @tigercosmos points out to me: our AppVeyor CI seems to use VS 2015? https://github.com/servo/servo/blob/master/appveyor.yml#L23 , maybe we should update the README accordingly? |
|
Error again.. |
|
That looks like your shell can't find git. |
|
@jdm No, the error is caused by vs shell. After launch VS shell by So I launch VS shell manually and |
|
Which exact folder did the vs shell |
|
It will enter |
fix windows build issue #18055 <!-- Please describe your changes on the following line: --> With some reasons, the windows and VS environment do not set the `env("PLATFORM")` variable. So, there's no need to check the variable, and set `os_type` equl to `pc-windows-msvc` as default. Then the script can get correct url to download `rustc`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #18055 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18145) <!-- Reviewable:end -->
|
Thanks for fixing this @tigercosmos, is the windows build readme up to date? |
|
Sure. There are another 2 commits related to this issue be merged previously. |
Hi all i've just reformated my machine.
I followed the instructions on the readme, (including installing Visual Studio 2017)
and now i get
any idea why?