Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub detects Servo as outdated version of Firefox #18057

Closed
atouchet opened this issue Aug 12, 2017 · 5 comments
Closed

GitHub detects Servo as outdated version of Firefox #18057

atouchet opened this issue Aug 12, 2017 · 5 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Aug 12, 2017

GitHub when loaded with Servo has recently started showing warnings that it detects it as an outdated version of Firefox. Also as far as I can tell they are starting to limit site functionality for old browsers where certain things such as being able to sort PRs and issues no longer works.

GitHub

Tested in Windows 10.

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Aug 12, 2017

I tried making a potential fix for this in #18040.

@paulrouget paulrouget mentioned this issue Aug 12, 2017
14 of 24 tasks complete
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Aug 13, 2017

I made a comment on the PR here stating that this does not look like a Servo bug, but rather a bug at GH's user agent detection algorithm.

@emilio
Copy link
Member

@emilio emilio commented Aug 13, 2017

Well, if we choose to go around with FF's user agent (which I think it's a reasonable choice), then I don't know how they could ever guess we're Servo.

@emilio
Copy link
Member

@emilio emilio commented Aug 13, 2017

So this is our problem, I agree with @jdm there :)

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Aug 16, 2017

This was fixed in #18040.

@atouchet atouchet closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.