Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrectly use request's origin when determining same origin requests #18147
Comments
bors-servo
added a commit
that referenced
this issue
Oct 14, 2017
(WIP) Use the correct origin in fetch Fixes #18147. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 21, 2017
(WIP) Use the correct origin in fetch Fixes #18147. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 25, 2017
Use the correct origin in fetch Fixes #18147. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 30, 2017
Use the correct origin in fetch Fixes #18147. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 15, 2017
Use the correct origin in fetch Fixes #18147. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #17521, under the http_redirect_fetch step 7, we are still using the request's current URL's origin when making a comparison with the location URL's origin. This is incorrect, but when using the following (correct) code of comparing the origins:
we encountered some WPT failures due to the code having an origin that is not what the WPT expects.