Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly use request's origin when determining same origin requests #18147

Closed
KiChjang opened this issue Aug 18, 2017 · 0 comments
Closed

Correctly use request's origin when determining same origin requests #18147

KiChjang opened this issue Aug 18, 2017 · 0 comments

Comments

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Aug 18, 2017

In #17521, under the http_redirect_fetch step 7, we are still using the request's current URL's origin when making a comparison with the location URL's origin. This is incorrect, but when using the following (correct) code of comparing the origins:

let same_origin = match request.origin {
    Origin::Origin(ref origin) => *origin == location_url.origin,
    Origin::Client => false,
};

we encountered some WPT failures due to the code having an origin that is not what the WPT expects.

bors-servo added a commit that referenced this issue Oct 14, 2017
(WIP) Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 21, 2017
(WIP) Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 25, 2017
Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 30, 2017
Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 15, 2017
Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.