Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reentrancy in TreeWalker::accept_node and NodeIterator::accept_node #18218

Closed
jdm opened this issue Aug 24, 2017 · 3 comments · Fixed by #18255
Closed

Prevent reentrancy in TreeWalker::accept_node and NodeIterator::accept_node #18218

jdm opened this issue Aug 24, 2017 · 3 comments · Fixed by #18255
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue C-has-open-pr There is a PR open that resolves the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented Aug 24, 2017 •
edited
Loading

accept_node implements the filter algorithm from the specification, but that algorithm has been updated since it was first written. We need to add an active flag to both TreeWalker and NodeIterator and update it appropriately according to the specification.

Code: components/script/dom/nodeiterator.rs, components/script/dom/treewalker.rs
Tests: ./mach test-wpt tests/wpt/web-platform-tests/dom/traversal
@jdm jdm added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. labels Aug 24, 2017
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@CYBAI
Copy link
Member

CYBAI commented Aug 24, 2017

@highfive: assign me

@highfive
Copy link

Hey @CYBAI! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Aug 24, 2017
@CYBAI CYBAI mentioned this issue Aug 26, 2017
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Aug 27, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
80a839b 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [ ]  There are tests for these changes OR
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 29, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
be11311 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 6, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
fc18fc5 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
@jdm jdm added the C-has-open-pr There is a PR open that resolves the issue label Oct 17, 2017
bors-servo pushed a commit that referenced this issue Oct 17, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
327cb98 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 17, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
f266582 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 18, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
27aaf0c 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 21, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=<try>
6be2082 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 21, 2017
Auto merge of #18255 - CYBAI:prevent-reentrancy-pr18218, r=jdm
1667fcc 
Update concept of node filter algorithm

Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18218 (github issue number if applicable).
- [X] These changes do not require tests because changes are minimal and the error was triggered by a test

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue C-has-open-pr There is a PR open that resolves the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update concept of node filter algorithm CYBAI/servo
3 participants
@jdm @highfive @CYBAI