Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule 'clean' targets don't all remove the test binaries #183

Closed
burg opened this issue Nov 8, 2012 · 0 comments
Closed

Submodule 'clean' targets don't all remove the test binaries #183

burg opened this issue Nov 8, 2012 · 0 comments
Labels

Comments

@burg
Copy link

@burg burg commented Nov 8, 2012

No description provided.

@burg burg closed this in a883590 Nov 8, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
…time

From High Resolution Time test suite
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
A positive spread value makes an inset shadow smaller, so take the clip
mode into account when computing the box shadow size.

Fixes servo#183

v2: Don't introduce extra variable.
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Inset box shadow fixes

Hi,

I found this project interesting and figured I try to contribute, so I looked at the open issues and tried to fix servo#183. I saw a couple more issues with inset box shadows, so here's an attempt to fix those.

I'm not exactly sure what's the best way to test these changes. I did manual testing, but pointers for a better method are appreciated.

Thanks,
Ander
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.