Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically ensure that switches on globals are exhaustive #18469

Open
asajeffrey opened this issue Sep 12, 2017 · 2 comments
Open

Statically ensure that switches on globals are exhaustive #18469

asajeffrey opened this issue Sep 12, 2017 · 2 comments
Assignees
@asajeffrey
Labels
A-content/script

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Sep 12, 2017

We have some unreachable()! code that depends on switches on globals being exhaustive, which is easy to get wrong, e.g. https://github.com/servo/servo/blob/72f0fda836ff97d33169cd1fc0d23d2d07ad74c6/components/script/dom/globalscope.rs#L495L506

This is most likely the root cause of #18467.
@asajeffrey asajeffrey self-assigned this Sep 12, 2017
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Sep 12, 2017 •
edited by CYBAI

IRC chat at https://mozilla.logbot.info/servo/20170912#c751150
@nox
Copy link
Member

@nox nox commented Sep 18, 2017

Killing DissimilarOriginWindow would help.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nox @asajeffrey
You can’t perform that action at this time.