Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT tests runner Python error #18708

Closed
gterzian opened this issue Oct 2, 2017 · 2 comments
Closed

WPT tests runner Python error #18708

gterzian opened this issue Oct 2, 2017 · 2 comments
Labels

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Oct 2, 2017

When I run ./mach test-wpt tests/wpt/web-platform-tests/fetch/http-cache

I get

File "/servo/tests/wpt/grouping_formatter.py", line 108, in suite_start
    self.number_of_tests = sum(len(tests) for tests in data["tests"].itervalues())
AttributeError: 'list' object has no attribute 'itervalues'

removing the call to itervalues at

self.number_of_tests = sum(len(tests) for tests in data["tests"].itervalues())
fixed it for me locally. Seems like the data is now a list, and not a dict?

Is this worth a PR or I am just getting something wrong in my local setup?

@jdm
Copy link
Member

@jdm jdm commented Oct 2, 2017

It is definitely worth a PR.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Nov 4, 2017

Fixed in #18724.

@KiChjang KiChjang closed this Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.